[alsa-devel] [PATCH V2] ASOC:DAPM: update DPCM runtime when mixer/mux changes

Nenghua Cao nhcao at marvell.com
Fri Dec 13 13:10:39 CET 2013


From: Nenghua Cao <nhcao at marvell.com>

V2 -> V1:

   Removes the flag and update DPCM always when mixer/mux changes, according
to Takashi's and Mark's suggestion.

>> Usually backward compatibility is concerned when something new breaks
>> the existing ones.  In your case, always updating DPCM would work,
>> too, even without an extra flag; it's just suboptimal.

>Right, and if we have separate versions then at some point we'll end up
>having to define DPCM versions of everything which is going to get
>tedious and error prone.
 

V1 -> V0:

     refined patch, and add flag into soc_mixer_control and soc_enum 
instead of the alsa core, according to Takashi's suggestion.

> You don't need to extend the ALSA core API for such a purpose.  It's
> ASoC-specific, so rather extend struct soc_mixer_control instead, if
> such a new flag is really needed.


Nenghua Cao (1):
  ASOC:DAPM: update DPCM runtime when mixer/mux changes

 sound/soc/soc-dapm.c |   28 ++++++++++++++++++++++++----
 1 files changed, 24 insertions(+), 4 deletions(-)



More information about the Alsa-devel mailing list