[alsa-devel] [PATCH] ASoC: omap-pcm: Lower the dma coherent mask to 32bits

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Dec 6 13:33:02 CET 2013


On Fri, Dec 06, 2013 at 11:31:52AM +0200, Peter Ujfalusi wrote:
> On 12/05/2013 09:28 PM, Russell King - ARM Linux wrote:
> > gives us the very last PFN which the bus associated with dev is able to
> > address.  Hmm - so I got the test wrong on both twice - they should both
> > be:
> > 
> >  	if (sizeof(mask) != sizeof(dma_addr_t) &&
> >  	    mask > (dma_addr_t)~0 &&
> >  	    dma_to_pfn(dev, ~0) < min(max_pfn, arm_dma_pfn_limit))
> > 		return 0;
> > 
> > since we want to fail if we have _more_ memory than the bus will allow.
> > Can you try the above in both locations please?
> 
> Thanks, works fine.
> I will be out for a long weekend so you can add my:
> 
> Tested-by: Peter Ujfalusi <peter.ujfalusi at ti.com>

Thanks Peter.


More information about the Alsa-devel mailing list