[alsa-devel] Independent of model for HP

[Kailang]

Attach it.
Thanks.

> At Wed, 4 Dec 2013 15:14:11 +0800,
> Kailang wrote:
>>
>> Hi Takashi,
>>
>> I forgot to remove one line for hp_automute_hook from
>> alc283_fixup_chromebook.
>
> Your MUA broke the spaces, so the patch can't be applied cleanly.
> Please give an attachment in that case.
>
>
> thanks,
>
> Takashi
>
>>
>> >From 251e68d32dd1028353b7eef3ae557be7c10fae8c Mon Sep 17 00:00:00 2001
>> From: Kailang Yang <kailang at realtek.com>
>> Date: Wed, 4 Dec 2013 15:06:14 +0800
>> Subject: [PATCH] ALSA: hda/realtek - remove hp_automute_hook from
>>  alc283_fixup_chromebook
>>
>> I forgot to remove the hp_automute_hook from alc283_fixup_chromebook.
>> It doesn't need this for other chrome os machine.
>>
>> Signed-off-by: Kailang Yang <kailang at realtek.com>
>>
>> diff --git a/sound/pci/hda/patch_realtek.c 
>> b/sound/pci/hda/patch_realtek.c
>> index d9509d76..d510a88 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -3666,7 +3666,6 @@ static void alc283_fixup_chromebook(struct 
>> hda_codec
>> *codec,
>>    snd_hda_override_wcaps(codec, 0x03, 0);
>>    /* Disable AA-loopback as it causes white noise */
>>    spec->gen.mixer_nid = 0;
>> -  spec->gen.hp_automute_hook = alc283_hp_automute_hook;
>>    break;
>>   case HDA_FIXUP_ACT_INIT:
>>    /* Enable Line1 input control by verb */
>>
>>
>> Thanks.
>> Kailang
>>
>>
>> > At Tue, 3 Dec 2013 16:12:49 +0800,
>> > Kailang wrote:
>> >>
>> >> Hi Takashi,
>> >>
>> >> I merged two patch to attach patch.
>> >> Change log also post on it.
>> >
>> > Thanks, it looks better now, and I applied it.
>> >
>> >
>> > Takashi
>> >
>> >>
>> >> Thanks.
>> >> Kailang.
>> >>
>> >>
>> >> > At Mon, 2 Dec 2013 17:21:43 +0800,
>> >> > Kailang wrote:
>> >> >>
>> >> >> Hi Takashi,
>> >> >>
>> >> >> HP Chrome Book, the headset jack was difference between other 
>> >> >> chrome
>> >> >> book.
>> >> >> It need to manual control Mic jack detect.
>> >> >
>> >> > So, this patch moves the thing to a model entry.  I see now the
>> >> > reason of the previous patch.
>> >> >
>> >> > But, please put what you wrote above into the patch changelog. 
>> >> > There
>> >> > is way too little description in the patch wrt the purpose and the
>> >> > implementation of the patch.
>> >> >
>> >> > And, if we define these different models here, the previous patch to
>> >> > remove PCI SSID entry can be merged into this single patch.  This
>> >> > would be less confusing, IMO.  (Of course, add the description in 
>> >> > the
>> >> > patch changelog as well.)
>> >> >
>> >> >
>> >> > thanks,
>> >> >
>> >> > Takashi
>> >> >
>> >> > ------Please consider the environment before printing this e-mail.
>> >> [2 0001-independent-of-model-hp.patch <application/octet-stream
>> >> (quoted-printable)>]
>> >>
>> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0000-remove-hp-automute-hook.patch
Type: application/octet-stream
Size: 938 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131204/daefd3ae/attachment.obj>