[alsa-devel] hda: Is it ok to enable SND_HDA_I915 to support Haswell Gfx power well by default?

[Takashi Iwai]

At Tue, 27 Aug 2013 11:00:32 +0000,
Lin, Mengdong wrote:
> 
> Hi Takashi,
> 
> Would you please add " default y" to SND_HDA_I915?

I took my posted patch as is now.


Takashi

> 
> Thanks
> Mengdong
> 
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai at suse.de]
> > Sent: Tuesday, August 27, 2013 5:57 PM
> > To: David Henningsson
> > Cc: Lin, Mengdong; alsa-devel at alsa-project.org
> > Subject: Re: hda: Is it ok to enable SND_HDA_I915 to support Haswell Gfx
> > power well by default?
> > 
> > At Tue, 27 Aug 2013 11:38:11 +0200,
> > David Henningsson wrote:
> > >
> > > On 08/27/2013 11:32 AM, Lin, Mengdong wrote:
> > > > Hi Takashi and David,
> > > >
> > > >
> > > >
> > > > Is it okay to enable SND_HDA_I915 by default?
> > >
> > > I think it should be automatically enabled if the user has selected
> > > both of snd-hda-intel and i915. And I thought it already was, but I
> > > haven't checked so I might very well be wrong.
> > 
> > It's not set to default=y.  But, it'd be even easier to get rid of the user
> > selection like below.
> > 
> > 
> > Takashi
> > 
> > ---
> > diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig index
> > 59c5e9c..8de66cc 100644
> > --- a/sound/pci/hda/Kconfig
> > +++ b/sound/pci/hda/Kconfig
> > @@ -152,14 +152,9 @@ config SND_HDA_CODEC_HDMI
> >  	  This module is automatically loaded at probing.
> > 
> >  config SND_HDA_I915
> > -	bool "Build Display HD-audio controller/codec power well support for i915
> > cards"
> > +	bool
> > +	default y
> >  	depends on DRM_I915
> > -	help
> > -	  Say Y here to include full HDMI and DisplayPort HD-audio
> > controller/codec
> > -	  power-well support for Intel Haswell graphics cards based on the i915
> > driver.
> > -
> > -	  Note that this option must be enabled for Intel Haswell C+ stepping
> > machines, otherwise
> > -	  the GPU audio controller/codecs will not be initialized or damaged when
> > exit from S3 mode.
> > 
> >  config SND_HDA_CODEC_CIRRUS
> >  	bool "Build Cirrus Logic codec support"
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>