[alsa-devel] [PATCH v2 2/2] ASoC: fsl_spdif: Reduce the noise on comments

Nicolin Chen b42378 at freescale.com
Mon Aug 26 08:07:29 CEST 2013


On Fri, Aug 23, 2013 at 06:14:46PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at freescale.com>
> 
> Remove the "====" pattern to let the comments cleaner and more uniform.
> 
> Also, do not use multi-line style for a single line comment. 
> 
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>

Well, I just wanted to make it distinct.

But I'm fairly okay with this patch.

Thank you.

Acked-by: Nicolin Chen <b42378 at freescale.com>

Best regards,
Nicolin Chen

> ---
> Changes since v1:
> - None
>  sound/soc/fsl/fsl_spdif.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index bf58086..34b531b 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -555,7 +555,6 @@ struct snd_soc_dai_ops fsl_spdif_dai_ops = {
>  
>  
>  /*
> - * ============================================
>   * FSL SPDIF IEC958 controller(mixer) functions
>   *
>   *	Channel status get/put control
> @@ -563,7 +562,6 @@ struct snd_soc_dai_ops fsl_spdif_dai_ops = {
>   *	Valid bit value get control
>   *	DPLL lock status get control
>   *	User bit sync mode selection control
> - * ============================================
>   */
>  
>  static int fsl_spdif_info(struct snd_kcontrol *kcontrol,
> @@ -942,11 +940,7 @@ static const struct snd_soc_component_driver fsl_spdif_component = {
>  	.name		= "fsl-spdif",
>  };
>  
> -/*
> - * ================
> - * FSL SPDIF REGMAP
> - * ================
> - */
> +/* FSL SPDIF REGMAP */
>  
>  static bool fsl_spdif_readable_reg(struct device *dev, unsigned int reg)
>  {
> -- 
> 1.8.1.2
> 
> 




More information about the Alsa-devel mailing list