[alsa-devel] [PATCH] ASoC: fsl: imx-wm8962: Fix missing audmux external port setup check

Andreas Pretzsch apr at cn-eng.de
Fri Aug 23 16:37:51 CEST 2013


Return value of imx_audmux_v2_configure_port(ext_port, ...) was not
assigned. Following check tested the preceding call (int_port).

Signed-off-by: Andreas Pretzsch <apr at cn-eng.de>
---
Fix not tested (no matching hardware), only noticed during code reading.

Patch against
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/wm8962

 sound/soc/fsl/imx-wm8962.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c
index 52a36a9..e018632 100644
--- a/sound/soc/fsl/imx-wm8962.c
+++ b/sound/soc/fsl/imx-wm8962.c
@@ -192,7 +192,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "audmux internal port setup failed\n");
 		return ret;
 	}
-	imx_audmux_v2_configure_port(ext_port,
+	ret = imx_audmux_v2_configure_port(ext_port,
 			IMX_AUDMUX_V2_PTCR_SYN,
 			IMX_AUDMUX_V2_PDCR_RXDSEL(int_port));
 	if (ret) {
-- 
1.7.10.4



More information about the Alsa-devel mailing list