[alsa-devel] [PATCH 2/2] ALSA: hda - Add workarounds for pop-noise on Chromebook with ALC283

[Takashi Iwai]

At Thu, 22 Aug 2013 11:45:57 +0200,
David Henningsson wrote:
> 
> On 08/22/2013 10:21 AM, Takashi Iwai wrote:
> > From: Kailang Yang <kailang at realtek.com>
> > 
> > The headphone automute on this machine triggers annoying pop noises.
> > It seems that only the first DAC can be used, the secondary DAC always
> > results in this problem.  This patch disables the secondary DAC with
> > a few additional workarounds.
> 
> Interesting. I have not heard of any such problems on the ALC283
> machines we have been dealing with. But a secondary DAC problem does
> sound like something codec specific rather than machine specific...

It's easy to escalate the fixup as codec-generic.  But disabling the
second DAC reduces the functionality pretty much, so I'd take a safer
approach for now.

> Also a nitpick: It's probably Chromebook, not ChromeBook or Chrome_book.

Corrected.  Also I found that the fixup won't work as is, since it's
added after the vendor-generic entry.  Fixed that too.


thanks,

Takashi


> > Signed-off-by: Kailang Yang <kailang at realtek.com>
> > Signed-off-by: Takashi Iwai <tiwai at suse.de>
> > ---
> >  sound/pci/hda/patch_realtek.c | 45 +++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 45 insertions(+)
> > 
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 4bdccd1..a97dbba 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -3394,6 +3394,45 @@ static void alc269_fixup_limit_int_mic_boost(struct hda_codec *codec,
> >  	}
> >  }
> >  
> > +static void alc283_hp_automute_hook(struct hda_codec *codec,
> > +				    struct hda_jack_tbl *jack)
> > +{
> > +	struct alc_spec *spec = codec->spec;
> > +	int vref;
> > +
> > +	msleep(200);
> > +	snd_hda_gen_hp_automute(codec, jack);
> > +
> > +	vref = spec->gen.hp_jack_present ? PIN_VREF80 : 0;
> > +
> > +	msleep(600);
> > +	snd_hda_codec_write(codec, 0x19, 0, AC_VERB_SET_PIN_WIDGET_CONTROL,
> > +			    vref);
> > +}
> > +
> > +static void alc283_chromebook_caps(struct hda_codec *codec)
> > +{
> > +	snd_hda_override_wcaps(codec, 0x03, 0);
> > +}
> > +
> > +static void alc283_fixup_chromebook(struct hda_codec *codec,
> > +				    const struct hda_fixup *fix, int action)
> > +{
> > +	struct alc_spec *spec = codec->spec;
> > +	int val;
> > +
> > +	switch (action) {
> > +	case HDA_FIXUP_ACT_PRE_PROBE:
> > +		alc283_chromebook_caps(codec);
> > +		spec->gen.hp_automute_hook = alc283_hp_automute_hook;
> > +		/* MIC2-VREF control */
> > +		/* Set to manual mode */
> > +		val = alc_read_coef_idx(codec, 0x06);
> > +		alc_write_coef_idx(codec, 0x06, val & ~0x000c);
> > +		break;
> > +	}
> > +}
> > +
> >  enum {
> >  	ALC269_FIXUP_SONY_VAIO,
> >  	ALC275_FIXUP_SONY_VAIO_GPIO2,
> > @@ -3430,6 +3469,7 @@ enum {
> >  	ALC269_FIXUP_ACER_AC700,
> >  	ALC269_FIXUP_LIMIT_INT_MIC_BOOST,
> >  	ALC269VB_FIXUP_ORDISSIMO_EVE2,
> > +	ALC283_FIXUP_CHROME_BOOK,
> >  };
> >  
> >  static const struct hda_fixup alc269_fixups[] = {
> > @@ -3681,6 +3721,10 @@ static const struct hda_fixup alc269_fixups[] = {
> >  			{ }
> >  		},
> >  	},
> > +	[ALC283_FIXUP_CHROME_BOOK] = {
> > +		.type = HDA_FIXUP_FUNC,
> > +		.v.func = alc283_fixup_chromebook,
> > +	},
> >  };
> >  
> >  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> > @@ -3729,6 +3773,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> >  	SND_PCI_QUIRK(0x103c, 0x1973, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> >  	SND_PCI_QUIRK(0x103c, 0x1983, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> >  	SND_PCI_QUIRK_VENDOR(0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED),
> > +	SND_PCI_QUIRK(0x103c, 0x21ed, "HP Falco ChromeBook", ALC283_FIXUP_CHROME_BOOK),
> >  	SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> >  	SND_PCI_QUIRK(0x1043, 0x115d, "Asus 1015E", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> >  	SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_DMIC),
> > 
> 
> 
> 
> -- 
> David Henningsson, Canonical Ltd.
> https://launchpad.net/~diwic
>