[alsa-devel] [PATCH] rme96 add stream synchronization and PM support

[Takashi Iwai]

At Tue, 13 Aug 2013 23:12:05 +0200,
Knut Petersen wrote:
> 
> @@ -2390,6 +2486,21 @@ snd_rme96_probe(struct pci_dev *pci,
>  		return err;
>  	}
>  	
> +#ifdef CONFIG_PM
> +	rme96->playback_suspend_buffer = vmalloc(RME96_BUFFER_SIZE);
> +	if (!rme96->playback_suspend_buffer) {
> +		snd_printk(KERN_ERR
> +			   "Failed to allocate playback suspend buffer!\n");
> +		return -ENOMEM;

Call snd_card_free().  Otherwise leaking.

> +	}
> +	rme96->capture_suspend_buffer = vmalloc(RME96_BUFFER_SIZE);
> +	if (!rme96->capture_suspend_buffer) {
> +		snd_printk(KERN_ERR
> +			   "Failed to allocate capture suspend buffer!\n");
> +		return -ENOMEM;

Ditto.


The first patch looks OK, so applied it.
Please resubmit only the second patch with the fixes.


thanks,

Takashi