[alsa-devel] [PATCH V4 1/4] ASoC: Samsung: I2S: Add quirks as driver data in I2S

[Stephen Warren]

On 08/12/2013 05:46 PM, Mark Brown wrote:
> On Mon, Aug 12, 2013 at 05:18:34PM -0600, Stephen Warren wrote:
>> On 08/12/2013 05:13 PM, Mark Brown wrote:
> 
>>>> (although I dare say that at least samsung,supports-rstclr
>>>> should be modified to use the new reset controller bindings)
> 
>>> Really?  That doesn't seem terribly sane - I had thought that
>>> was for bodging resets on the side of things that don't
>>> normally have them or need board specific logic.  Also note
>>> that this is actually a magic register write done to reset the
>>> IP on some specific IPs.
> 
>> I believe that's exactly what the reset subsystem and associated
>> DT bindings were designed for.
> 
> That seems...  interesting.  It seems like this is fairly core
> device functionality I'd expect the driver to just be able to
> understand;  the main thing this property was doing was deciding if
> the reset was needed. I'm not sure I see the benefit here?

Sorry, I'm confused here. In this case, the reset is something
internal to the IP module, not sourced by an external reset
controller, so there's no need to involve the reset controller
bindings or subsystem.