[alsa-devel] [PATCH 2/3] ASoC: hdmi-codec: enable OF support

[Barry Song]

2013/7/17 Mark Brown <broonie at kernel.org>:
> On Wed, Jul 17, 2013 at 09:49:10AM +0100, Mark Rutland wrote:
>> On Wed, Jul 17, 2013 at 07:12:15AM +0100, Barry Song wrote:
>
>> > this makes users be able to add a hdmi-codec node in dts instead of
>> > hardcoding a platform device in mach.
>
>> Similarly to my comment on the first patch, I'm not sure this is the
>> best way to wire this up to devicetree. Can this not be hung off of hdmi
>> controller drivers?
>
> This one is different to the BT case - as you say it's hanging off the
> HDMI controller so the HDMI controller ought to enumerate it either as a
> stub or by actually seeing a device.  The platform device is fine but
> it's not something that should appear in the DT unless it's conveying
> some information about what's connected there (eg, power supplies for
> something soldered down on the board).

it should be ok that the platform_device is allocated and added in the
HDMI controller codes.

-barry