[alsa-devel] [PATCH] ASoC: rt5640: remove unused mux

[Bard Liao]

> -----Original Message-----
> From: Lars-Peter Clausen [mailto:lars at metafoo.de]
> Sent: Thursday, August 01, 2013 8:05 PM
> To: Bard Liao
> Cc: broonie at kernel.org; lgirdwood at gmail.com; Oder Chiou;
> alsa-devel at alsa-project.org; swarren at nvidia.com; swarren at wwwdotorg.org;
> Flove
> Subject: Re: [alsa-devel] [PATCH] ASoC: rt5640: remove unused mux
> 
> On 08/01/2013 01:29 PM, bardliao at realtek.com wrote:
> > From: Bard Liao <bardliao at realtek.com>
> >
> > Remove unused "INL Mux" and "INR Mux".
> >
> > Signed-off-by: Bard Liao <bardliao at realtek.com>
> > ---
> > I meet a kernel panic issue if I don't remove the unused widget and modify
> something in rt5640_dapm_widgets[] and/or rt5640_dapm_routes[].
> > The message is "Unable to handle kernel paging request at virtual address
> 6b6b6bd3".
> > PC is at dapm_clear_walk_output+0x18/0x7c LR is at
> > dapm_clear_walk_output+0x18/0x7c If I remove those unused widget, ie.
> > not appear in rt5640_dapm_routes[], everything is fine.
> > So I think they should be removed.
> 
> The kernel panic is my fault. I introduced a memory corruption bug in the
> ASoC DAPM core. It's not specific to this drivers, I'll send the fix in a minute.

Thanks for your clarification.
However, I think those two widgets should be removed still.
Because there is no those MUXs in RT5640 codec in fact.

> 
> - Lars
> 
> ------Please consider the environment before printing this e-mail.