[alsa-devel] Solved Hercules RMX2

[Gabriel M. Beddingfield]

+Daniel Mack <daniel at caiaq.de> (I think he's doing a lot of USB audio 
maint. these days)

On 04/16/2013 08:12 AM, Daniel Schürmann wrote:
> Hi Gabriel,
>
> Thank you for your quick response.
> The patch against the alsa-kernel is also attached at
> https://bugs.launchpad.net/mixxx/+bug/1096687 and here:

OK, I see now.  FYI, most maintainers prefer that you submit patches 
according to the guidelines in Documentation/SubmittingPatches.  (I'm 
not a maintainer, BTW...)

>
> diff --git a/sound/usb/helper.c b/sound/usb/helper.c
> index c1db28f..e044804 100644
> --- a/sound/usb/helper.c
> +++ b/sound/usb/helper.c
> @@ -23,6 +23,9 @@
>   #include "helper.h"
>   #include "quirks.h"
>
> +/* Hercules RMX2 needs 1240 ms for setting the sample rate the first time */
> +#define USB_MSG_TIMEOUT 1500
> +
>   /*
>    * combine bytes and get an integer value
>    */
> @@ -93,7 +96,7 @@ int snd_usb_ctl_msg(struct usb_device *dev, unsigned int pipe, __u8 request,
>   			return -ENOMEM;
>   	}
>   	err = usb_control_msg(dev, pipe, request, requesttype,
> -			      value, index, buf, size, 1000);
> +			      value, index, buf, size, USB_MSG_TIMEOUT);
>   	if (size > 0) {
>   		memcpy(data, buf, size);
>   		kfree(buf);

This changes the value for every USB audio device... not just the RMX2. 
  Daniel, is there a better way to do this?

-gabriel