[alsa-devel] [PATCH 2/3] ALSA: compress_core: Split copy into seperate read and write callbacks

[Takashi Iwai]

At Tue, 9 Apr 2013 12:47:28 +0100,
Mark Brown wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> On Tue, Apr 09, 2013 at 04:45:07PM +0530, Vinod Koul wrote:
> > On Fri, Apr 05, 2013 at 09:23:45AM +0100, Charles Keepax wrote:
> > > On Thu, Apr 04, 2013 at 01:01:57PM -0500, Pierre-Louis Bossart wrote:
> 
> > > > Why not remove the const to make this consistent with the PCM interface?
> 
> > > I had been trying to avoid loosing the const from the write file
> > > operation, however I am happy to just loose this through casting
> > > instead. It is certainly a simpler change I will respin these to
> > > do so.
> 
> > Keeping const of write seems to be a better idea... Ah i cant decide :(
> > I will asker wiser folks... Takashi, Mark?
> 
> I generally prefer the const correctness, but on the other hand Pierre
> is right about the PCM interface and it's probably more trouble than
> it's worth to change that.  So meh, dunno :/

I'm inclined to take an easier approach, just removing const, in such
a case.

If we do split to read & write, it should be done for PCM as well.
There are only handful users, so it shouldn't be too hard.


Takashi