[alsa-devel] [PATCH v5 1/2] ALSA: ASoC: davinci-mcasp: don't configure AFSX direction in DIT mode

Yegor Yefremov yegorslists at googlemail.com
Thu Apr 4 12:49:32 CEST 2013


On Thu, Mar 7, 2013 at 2:38 PM,  <yegorslists at googlemail.com> wrote:
> From: Yegor Yefremov <yegorslists at googlemail.com>
>
> AFSX won't be used in DIT mode. The related pins are AHCLKX and
> the data pins.
>
> Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
> Acked-by: Vaibhav Bedia <vaibhav.bedia at ti.com>
> Tested-by: Daniel Mack <zonque at gmail.com>
> ---
> v5: add Daniel's Tested-by
> v4: change subjuct to include "ALSA: ASoC: "
>
>  sound/soc/davinci/davinci-mcasp.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 9321e5c..90a9b99 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -772,9 +772,6 @@ static void davinci_hw_param(struct davinci_audio_dev *dev, int stream)
>  /* S/PDIF */
>  static void davinci_hw_dit_param(struct davinci_audio_dev *dev)
>  {
> -       /* Set the PDIR for Serialiser as output */
> -       mcasp_set_bits(dev->base + DAVINCI_MCASP_PDIR_REG, AFSX);
> -
>         /* TXMASK for 24 bits */
>         mcasp_set_reg(dev->base + DAVINCI_MCASP_TXMASK_REG, 0x00FFFFFF);
>
> --
> 1.7.7
>

Mark, could you please take a look at this patch and queue for 3.10?

Thanks.

Yegor


More information about the Alsa-devel mailing list