[alsa-devel] [asoc:for-3.7 95/95] sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

[Julia Lawall]

On Wed, 5 Sep 2012, Fengguang Wu wrote:

> On Wed, Sep 05, 2012 at 03:55:13PM +0200, Julia Lawall wrote:
> > On Wed, 5 Sep 2012, Fengguang Wu wrote:
> >
> > > On Wed, Sep 05, 2012 at 03:33:26PM +0200, Julia Lawall wrote:
> > > > On Wed, 5 Sep 2012, Mark Brown wrote:
> > > >
> > > > > On Wed, Sep 05, 2012 at 01:56:09PM +0800, Fengguang Wu wrote:
> > > > > > On Wed, Sep 05, 2012 at 06:40:25AM +0100, Mark Brown wrote:
> > > > > > > On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:
> > > > >
> > > > > > > Julia generally does a pretty good job of formatting her mails, perhaps
> > > > > > > there's some scripts she uses whcih would help?
> > > > >
> > > > > > Julia Lawall? Added CC to her.
> > > > >
> > > > > Yes.
> > > >
> > > > I'm missing some context...
> > >
> > > Julia, you've posted some pretty neat (coccinelle generated?) patches
> > > to the list. So we wonder whether you have some scripts for formatting
> > > patches based on the coccinelle output?
> >
> > I do have a tool, but it doesn't exactly take the output produced by
> > coccicheck.  I can look into how this could be done.
> >
> > The input desired would be the text printed by Coccinelle and a patch
> > generated by git?
>
> I'm just adapting the coccinelle generated diff into a mechanically
> formated patch.
>
> Here is the discussed patch, generated by a simple script.
> It mainly serves as a good start point for patch submission.
>
> : [PATCH] wm0010: fix coccinelle warnings
> :
> : sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
> :
> :  Make sure threaded IRQs without a primary handler are always request with
> :  IRQF_ONESHOT
> :
> : Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
> :
> : Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
> : ---
> :
> : Please take the patch only if it's a positive warning. Thanks!
> :
> :  cocci-output-17570-fcfaec-wm0010.c |    2 +-
> :  1 file changed, 1 insertion(+), 1 deletion(-)
> :
> : --- a/sound/soc/codecs/wm0010.c
> : +++ b/sound/soc/codecs/wm0010.c
> : @@ -847,7 +847,7 @@ static int wm0010_probe(struct snd_soc_c
> :                 trigger = IRQF_TRIGGER_FALLING;
> :         trigger |= IRQF_ONESHOT;
> :
> : -       ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger,
> : +       ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger | IRQF_ONESHOT,
> :                                    "wm0010", wm0010);
> :         if (ret)
> :                 dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n",
> :

I'm not sure what could be done better...

julia