[alsa-devel] [asoc:topic/adsp 139/139] sound/soc/codecs/wm_adsp.c:556:4: warning: suggest parentheses around comparison in operand of '&'

kbuild test robot fengguang.wu at intel.com
Wed Nov 28 19:08:03 CET 2012


tree:   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/adsp
head:   973838a030d2a91fbd524c95281991510ed0a865
commit: 973838a030d2a91fbd524c95281991510ed0a865 [139/139] ASoC: wm_adsp: Enable DVFS for ADSP2
config: make ARCH=x86_64 allmodconfig

All warnings:

sound/soc/codecs/wm_adsp.c: In function 'wm_adsp2_event':
sound/soc/codecs/wm_adsp.c:556:4: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]

vim +556 sound/soc/codecs/wm_adsp.c

2159ad93 Mark Brown 2012-10-11  540  	struct wm_adsp *dsps = snd_soc_codec_get_drvdata(codec);
2159ad93 Mark Brown 2012-10-11  541  	struct wm_adsp *dsp = &dsps[w->shift];
973838a0 Mark Brown 2012-11-28  542  	unsigned int val;
2159ad93 Mark Brown 2012-10-11  543  	int ret;
2159ad93 Mark Brown 2012-10-11  544  
2159ad93 Mark Brown 2012-10-11  545  	switch (event) {
2159ad93 Mark Brown 2012-10-11  546  	case SND_SOC_DAPM_POST_PMU:
973838a0 Mark Brown 2012-11-28  547  		if (dsp->dvfs) {
973838a0 Mark Brown 2012-11-28  548  			ret = regmap_read(dsp->regmap,
973838a0 Mark Brown 2012-11-28  549  					  dsp->base + ADSP2_CLOCKING, &val);
973838a0 Mark Brown 2012-11-28  550  			if (ret != 0) {
973838a0 Mark Brown 2012-11-28  551  				dev_err(dsp->dev,
973838a0 Mark Brown 2012-11-28  552  					"Failed to read clocking: %d\n", ret);
973838a0 Mark Brown 2012-11-28  553  				return ret;
973838a0 Mark Brown 2012-11-28  554  			}
973838a0 Mark Brown 2012-11-28  555  
973838a0 Mark Brown 2012-11-28 @556  			if (val & ADSP2_CLK_SEL_MASK >= 3) {
973838a0 Mark Brown 2012-11-28  557  				ret = regulator_enable(dsp->dvfs);
973838a0 Mark Brown 2012-11-28  558  				if (ret != 0) {
973838a0 Mark Brown 2012-11-28  559  					dev_err(dsp->dev,
973838a0 Mark Brown 2012-11-28  560  						"Failed to enable supply: %d\n",
973838a0 Mark Brown 2012-11-28  561  						ret);
973838a0 Mark Brown 2012-11-28  562  					return ret;
973838a0 Mark Brown 2012-11-28  563  				}
973838a0 Mark Brown 2012-11-28  564  

---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation


More information about the Alsa-devel mailing list