[alsa-devel] [PATCH 1/1] ALSA: CA0132 - Handle endianness of SCP buffer data

Takashi Iwai tiwai at suse.de
Wed Nov 28 09:14:12 CET 2012


At Wed, 28 Nov 2012 08:11:11 +0100,
Takashi Iwai wrote:
> 
> At Tue, 27 Nov 2012 19:04:47 -0800,
> Ian Minett wrote:
> > 
> > From: Ian Minett <ian_minett at creativelabs.com>
> > 
> > Handle endianness of the SCP buffer being sent to or from the
> > DSP chip on big-endian host architectures.
> > The SCP buffer is prepared in dspio_scp(), and bytes are swapped 
> > before being transferred by the codec in dspio_send().
> > Based on branch origin/topic/hda-ca0132-dsp.
> > 
> > We would appreciate any feedback you may have.
> 
> It's more straightforward to use cpu_to_le32() and le32_to_cpu()
> than unaligned access.
> 
> Could you resend the patch with this rewrite?

BTW, I rebased topic/hda-ca0132-dsp branch on my sound and
sound-unstable git trees.  It's JFYI.


Takashi


More information about the Alsa-devel mailing list