[alsa-devel] [PATCH] ALSA: snd-usb: properly initialize the sync endpoint

Takashi Iwai tiwai at suse.de
Thu Nov 22 21:23:36 CET 2012


At Thu, 22 Nov 2012 20:27:59 +0100,
Daniel Mack wrote:
> 
> Jeffrey Barish reported an obvious bug in the pcm part of the usb-audio
> driver which causes the code to not initialize the sync endpoint from
> configure_endpoint().
> 
> Reported-by: Jeffrey Barish <jeff_barish at earthlink.net>
> Signed-off-by: Daniel Mack <zonque at gmail.com>
> Cc: stable at kernel.org [3.5+]

Thanks, applied.


Takashi

> ---
>  sound/usb/pcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index bc3c9ac..e919c2e 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -458,7 +458,7 @@ static int configure_endpoint(struct snd_usb_substream *subs)
>  		return ret;
>  
>  	if (subs->sync_endpoint)
> -		ret = snd_usb_endpoint_set_params(subs->data_endpoint,
> +		ret = snd_usb_endpoint_set_params(subs->sync_endpoint,
>  						  subs->pcm_format,
>  						  subs->channels,
>  						  subs->period_bytes,
> -- 
> 1.7.11.7
> 


More information about the Alsa-devel mailing list