[alsa-devel] [PATCH 4/4] ASoC: firmware core: Add core support to create and destroy firmware components.

[Takashi Iwai]

At Tue, 20 Nov 2012 12:03:25 +0000,
Liam Girdwood wrote:
> 
> On 19/11/12 18:46, Takashi Iwai wrote:
> 
> > I find the idea is great.  Looking through the patch, a few things
> > came to my mind:
> >
> > - Endianness and alignment
> > - Forward-compatibility
> > - Avoid the bitfield usages
> >
> > About endianness: the firmware is usually provided as
> > endian-independent.  That is, the driver is supposed to convert to CPU
> > endianness properly, or check and reject the invalid firmware, at
> > least.
> >
> 
> Yeah, that's something we don't convert atm, but we do check with a u32 magic 
> number in each header (and will reject that object if the header is missing or 
> incorrect).

That's what I expected.

Then it'd be helpful if the driver checks about the wrong endian,
too, instead of some unknown error.


Takashi