[alsa-devel] [PATCH] ASoC: codecs/wm8978: Only reconfigure GPIO1 when used for PLL output

[Eric Millbrandt]

On 2012-11-15 Mark Brown wrote:
> On Tue, Nov 13, 2012 at 09:43:08AM -0500, Eric Millbrandt wrote:
>
>> However, I agree that the handling of the pin is odd.  Does OPCLK
>> really need to be reconfigured as input whenever the PLL values are
>> updated?  I didn't see anything in the user manual to suggest that that
>> needed to be
> done.
>
> It should not be a requirement of the device itself.  It might be a
> requirement of something using the clock but the system doing that
> should take care of remuxing the pin as needed.  What I'd suggest doing
> here is removing the management of the pin completely from this
> function.

That sounds reasonable.  I'll make those changes and resubmit.

Eric




This e-mail and the information, including any attachments, it contains are intended to be a confidential communication only to the person or entity to whom it is addressed and may contain information that is privileged. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately notify the sender and destroy the original message.

Thank you.

Please consider the environment before printing this email.