[alsa-devel] [PATCH v2] ASoC: mxs-pcm: Fix fifo size

[Mark Brown]

On Sat, Nov 03, 2012 at 04:04:02AM +0800, Dong Aisheng wrote:
> On 2 November 2012 23:06, Mark Brown
> > On Wed, Oct 31, 2012 at 03:06:11PM -0200, Fabio Estevam wrote:

> >> According to MX28 Reference Manual the SAIF FIFO contains four 32-bit entries.

> >> -     .fifo_size              = 32,
> >> +     .fifo_size              = 4,

> > fifo_size should be specified in bytes so the original code looks
> > correct?

> Then, probably it should be 16.

Yup.

> BTW, it seems this param is not used anymore:
> http://www.alsa-project.org/~tiwai/writing-an-alsa-driver/ch05s05.html
> That may be the reason why i see some other platforms pcm code just
> set fifo_size to 0.

Hrm, right - that'll be why nobody noticed.  Guess it doesn't matter any
more.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20121106/98953948/attachment.sig>