[alsa-devel] [PATCH 1/2] HDA: Fix digital microphone on CS420x

[Daniel J Blueman]

On 4 November 2012 16:16, Takashi Iwai <tiwai at suse.de> wrote:

> At Sun,  4 Nov 2012 13:19:03 +0800,
> Daniel J Blueman wrote:
> >
> > Correctly enable the digital microphones with the right bits in the
> right coeffecient
> > registers on Cirrus CS4206/7 codecs. It also prevents misconfiguring
> ADC1/2.
> >
> > This fixes the digital mic on the Macbook Pro 10,1/Retina.
> >
> > Based-on-patch-by: Alexander Stein <
> alexander.stein at systec-electronic.com>
> > Signed-off-by: Daniel J Blueman <daniel at quora.org>
>
> Thanks, this looks more comprehensive.  DIG1 and DIG2 seem to have
> been set wrongly in the original code, based on the Cirrus's example
> code.  Is the right-only recording problem fixed by this patch?
>

It is fixed. In the mbp101 init verbs, setting the vendor widget ADC
configuration bit 12 to copy the ADC2 right channel to the left (0x1004 to
nid 0x11 coef 2) is superfluous here, so presumably for the analogue mic
in. I'll get time later to check all this.

The second coefficient index initialisation (0x000f to nid 0x11 coef 4) is
now redundant, as we enable the mic bits later correctly now. I'll send an
updated patch which drops this.

Alexander, could you check this doesn't break your machine?
>
[...]
-- 
Daniel J Blueman