[alsa-devel] [PATCH v3 1/2] ASoC: mxs-saif: Remove platform data

[Dong Aisheng]

Hi Fabio,

On 31 October 2012 23:55, Fabio Estevam <festevam at gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam at freescale.com>
>
> All MXS users have been converted to device tree and the board files have been
> removed.
>
> No need to keep platform data in the driver.
>
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>

Only one minor comment, otherwise,
Acked-by: Dong Aisheng <dong.aisheng at linaro.org>

> ---
> Changes since v2:
> - Also remove 'if (np)' as dt is the only probing mechanism.
> Changes since v1:
> - Also remove mxs_saif_platform_data and sound/saif.h, which was used only
> to include mxs_saif_platform_data definition.
>  include/sound/saif.h     |   16 ----------------
>  sound/soc/mxs/mxs-saif.c |   42 +++++++++++++++---------------------------
>  2 files changed, 15 insertions(+), 43 deletions(-)
>  delete mode 100644 include/sound/saif.h
>
> diff --git a/include/sound/saif.h b/include/sound/saif.h
> deleted file mode 100644
> index f22f3e1..0000000
> diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
> index aa037b2..ab5bdec 100644
> --- a/sound/soc/mxs/mxs-saif.c
> +++ b/sound/soc/mxs/mxs-saif.c
> @@ -32,7 +32,6 @@
>  #include <sound/pcm.h>
>  #include <sound/pcm_params.h>
>  #include <sound/soc.h>
> -#include <sound/saif.h>
>  #include <asm/mach-types.h>
>  #include <mach/hardware.h>
>  #include <mach/mxs.h>
> @@ -652,10 +651,9 @@ static int __devinit mxs_saif_probe(struct platform_device *pdev)
>         struct device_node *np = pdev->dev.of_node;
>         struct resource *iores, *dmares;
>         struct mxs_saif *saif;
> -       struct mxs_saif_platform_data *pdata;
>         struct pinctrl *pinctrl;
>         int ret = 0;
> -
> +       struct device_node *master;
>
>         if (!np && pdev->id >= ARRAY_SIZE(mxs_saif))

Can we also clean up this line?
It seems pdev->id checking is also needless after converting to dt only.

>                 return -EINVAL;

Regards
Dong Aisheng