[alsa-devel] [PATCH 4/4] ASoC: omap-abe-twl6040: Add device tree support

[Mark Brown]

On Tue, May 08, 2012 at 03:15:14PM +0300, Peter Ujfalusi wrote:

> 	abe-twl6040,jack_detection = <0>;

Shouldn't this be a boolean property that simply needs to be present to
flag detection?

> 	dai-link1,codec = <&twl6040_codec>;
> 	dai-link1,dai = <&mcpdm>;

This seems like it ought to be an array of nodes, one per link, instead
of having an index in the property name.  It should certainly be easier
to parse.

It also seems like it's not at all board specific and should be factored
out.

> 	abe-twl6040,audio-routing =
> 		"Headset Stereophone", "HSOL",
> 		"Headset Stereophone", "HSOR",

Binding should document what the board-defined nodes are.

> +Example:
> +
> +sound { /* ASoC */
> +	compatible = "ti,abe-twl6040";
> +	abe-twl6040,model = "SDP4430";

Please don't repeat your binding documentation in the changelog, it's
already in the patch and means it comes after the documentation.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120508/f2b31769/attachment.sig