[alsa-devel] [PATCH 1/2] ASoC: sgtl5000: Convert mic bias to a supply widget

[Mark Brown]

On Thu, Mar 29, 2012 at 01:24:13PM +0800, Shawn Guo wrote:
> On Wed, Mar 28, 2012 at 08:53:45PM +0100, Mark Brown wrote:

> > -	SND_SOC_DAPM_MICBIAS_E("Mic Bias", SGTL5000_CHIP_MIC_CTRL, 8, 0,
> > -				mic_bias_event,
> > -				SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD),
> > +	SND_SOC_DAPM_SUPPLY("Mic Bias", SGTL5000_CHIP_MIC_CTRL, 8, 0,
> > +			    mic_bias_event,
> > +			    SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD),

> It breaks my capture testing.

Well, any capture testing that uses mic bias shouldn't work in mainline
anyway - there's no hookup in the machine driver.

> I'm not sure these two macros are equivalent, since they have different
> .id assignment.  To quickly confirm the problem, I have the capture
> back to work with the following change.

You'll need to change the hookup in your machine to adapt to the change
of widget type - see the previous conversions that have been done in git
history for examples.  No device tree bindings should be using old style
mic bias hookups.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120329/36c5a4cc/attachment.sig