[alsa-devel] [PATCH 2/8] sound:asoc: Add support for synopsys i2s controller as per ASoC framework.

[Mark Brown]

On Mon, Mar 26, 2012 at 02:33:22PM +0530, Rajeev kumar wrote:
> On 3/20/2012 9:14 PM, Mark Brown wrote:
> >On Tue, Mar 20, 2012 at 05:03:46PM +0530, Rajeev Kumar wrote:

> >>+		if (dev->i2s_clk_cfg(config)) {
> >>+			dev_err(dev->dev, "runtime audio clk config fail\n");
> >>+			if (cpu_dai->driver->ops->trigger) {
> >>+				int ret =
> >>+					cpu_dai->driver->ops->trigger(substream,
> >>+							SNDRV_PCM_TRIGGER_STOP,
> >>+							cpu_dai);
> >>+				if (ret<  0) {
> >>+					dev_err(dev->dev,
> >>+							"trigger stop fail\n");
> >>+					return ret;
> >>+				}
> >>+			}

> >No, return an error if you encounter an error!

> You need not to stop controller in case clock fail ?

Let the upper layers worry about that.  Don't randomly change the state
of the controller without them knowing about it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120326/77c24b3c/attachment.sig