[alsa-devel] [PATCH 1/8] sound:asoc: Add support for STA529 Audio Codec

[Rajeev kumar]

Hello Lars,

On 3/23/2012 2:21 PM, Lars-Peter Clausen wrote:
> On 03/23/2012 05:00 AM, Rajeev kumar wrote:
>> Hello Lars,
>>
>> On 3/20/2012 11:27 PM, Lars-Peter Clausen wrote:
>>> On 03/20/2012 12:33 PM, Rajeev Kumar wrote:
>>>> +static const char *interface_mode_text[] = { "slave", "master"};
>>>
>>> Master/slave mode should be configured using the set_dai_fmt callback.
>>>
>> You mean to say with the help of clock direction. I think you can do it
>> in either way.
>> By this,  I am giving full control to user for the selection.
>
> Maybe I'm misunderstanding what this control does. But if it is about
> putting the CODEC in master or slave mode, so whether it should generate the
> frame- and bitclocks or if the other end of the DAI link should do it, then
> this should be configured using set_dai_fmt. Making this runtime selectable
> from userspace doesn't make much sense since both sides of the DAI link have
> to agree on who is master and who is slave. If you just change one side the
> link will just stop working.
>

Yes, This will put CODEC in master or slave mode.
OK I will do it in set_dai_fmt.

>>> [...]
>>>> +
>>>> +static int sta529_i2c_remove(struct i2c_client *client)
>>> __devexit
>>>> +{
>>>> +	snd_soc_unregister_codec(&client->dev);
>>>> +	kfree(i2c_get_clientdata(client));
>>>> +	return 0;
>>>> +}
>>> river");
>>
>> This comment is not clear to me , please explain.
>
> Annotate the remove function with __devexit. Like this:
> +static int __devexit sta529_i2c_remove(struct i2c_client *client)
>

Ok,

Best Regards
Rajeev

> .
>