[alsa-devel] [PATCH v3 09/11] ASoC: fsl: remove the fatal error checking on codec-handle

[Timur Tabi]

Shawn Guo wrote:
> sound {
>       compatible = "fsl,imx51-babbage-sgtl5000",
>                    "fsl,imx-audio-sgtl5000";
>       model = "imx51-babbage-sgtl5000";
>       ssi-controller = <&ssi1, &ssi2>;
>       audio-codec = <&sgtl5000_1, &sgtl5000_2>;
>       mux-int-port = <1>;
>       mux-ext-port = <3>;
> };

Based on Mark's other email, I would rather see this:

sound1 {
      compatible = "fsl,imx51-babbage-sgtl5000",
                   "fsl,imx-audio-sgtl5000";
      model = "imx51-babbage-sgtl5000";
      ssi-controller = <&ssi1>;
      audio-codec = <&sgtl5000_1>;
      mux-int-port = <1>;
      mux-ext-port = <3>;
};

sound2 {
      compatible = "fsl,imx51-babbage-sgtl5000",
                   "fsl,imx-audio-sgtl5000";
      model = "imx51-babbage-sgtl5000";
      ssi-controller = <&ssi2>;
      audio-codec = <&sgtl5000_2>;
      mux-int-port = <1>;
      mux-ext-port = <3>;
};

(ignoring for the moment that I have no idea what the mux-xxx-port values
in sound2 should be)

This makes it clear that ssi1 connects only to sgtl5000_1.

If you're okay with this, then please update the documentation accordingly.

-- 
Timur Tabi
Linux kernel developer at Freescale