[alsa-devel] [PATCH 10/16] arm: ux500: Add support for MSP I2S-devices

[Mark Brown]

On Wed, Mar 14, 2012 at 10:39:03AM +0100, Linus Walleij wrote:
> On Tue, Mar 13, 2012 at 10:40 PM, Mark Brown
> >>  arch/arm/mach-ux500/board-mop500-msp.c |  194 ++++++++++++++++++++++++++++++++
> >>  arch/arm/mach-ux500/board-mop500.c     |    7 +-
> >>  arch/arm/mach-ux500/board-mop500.h     |    1 +

> > Perhaps this is somehow idiomatic for the port but why is this in what
> > looks like a board specific rather than SoC specific file?

> Basically because it includes GPIO's which are board-specific.

> But with some cleverness I guess it'd be possible to split just
> the board-dependent stuff (i.e. GPIO) to board-mop500-msp.c
> and all SoC-specific stuff into say cpu-db8500-msp.c or
> even cpu-dbx500-msp.c if it's generic across all families
> of DBx500.

It doesn't even need to be particularly clever - the SoCs that need it
are all succesfully splitting the pin configuration from the basic
device registration so there's plenty of patterns to follow.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120314/60f78605/attachment.sig