[alsa-devel] [PATCH 14/16] ASoC: Ux500: Add platform-driver

[Linus Walleij]

On Tue, Mar 13, 2012 at 11:48 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:

>> +     cdesc = dma_dev->device_prep_dma_cyclic(ux500_pcm_data->pipeid, dma_addr,
>> +                                             period_cnt * period_len, period_len,
>> +                                             direction);
>
> You're using dmaengine here it seems.  Please refactor to use the
> dmaengine helper library that was recently contributed by Lars-Peter -
> it should save a bunch of code and make rolling out dmaengine framework
> improvements much easier.

That stuff is not even in linux-next so I don't know it it will even be
in v3.4. But let's see.

Yours,
Linus Walleij