[alsa-devel] [PATCH 1/1] ALSA: hdspm - Provide ioctl_compat

[Takashi Iwai]

At Thu,  8 Mar 2012 15:38:04 +0100,
Adrian Knoth wrote:
> 
> snd_hdspm uses its own ioctls to acquire config- and status information.
> Expose the corresponding ioctl handler via ioctl_compat, so that 32bit
> applications can use it on 64bit kernels.
> 
> Signed-off-by: Adrian Knoth <adi at drcomp.erfurt.thur.de>

Applied now.  Thanks.

We can make the hwdep ioctl compat handler to use ioctl if
ioctl_compat is NULL.  It'd work in most cases like this.  But some
driver may not allow the compat, so it's not entirely safe until we
investigate through the tree...


Takashi

> diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
> index 942cbe6..603cfc5 100644
> --- a/sound/pci/rme9652/hdspm.c
> +++ b/sound/pci/rme9652/hdspm.c
> @@ -6345,6 +6345,7 @@ static int __devinit snd_hdspm_create_hwdep(struct snd_card *card,
>  
>  	hw->ops.open = snd_hdspm_hwdep_dummy_op;
>  	hw->ops.ioctl = snd_hdspm_hwdep_ioctl;
> +	hw->ops.ioctl_compat = snd_hdspm_hwdep_ioctl;
>  	hw->ops.release = snd_hdspm_hwdep_dummy_op;
>  
>  	return 0;
> -- 
> 1.7.9.1
>