Shawn Guo wrote: > Yeah, it makes the diff neat. However I would make it an inline > function which is easier to play. However you want to do it is fine with me, although I would use "u32 __iomem *addr" instead of "void __iomem *addr". -- Timur Tabi Linux kernel developer at Freescale