[alsa-devel] [PATCH] ALSA: hda - add power states information in proc

[Takashi Iwai]

At Tue,  5 Jun 2012 18:08:10 +0800,
Wang Xingchao wrote:
> 
> add more power states information:
> - reset status
> - clock stop ok
> - power states error
> 
> Signed-off-by: Wang Xingchao <xingchao.wang at intel.com>
> ---
>  sound/pci/hda/hda_codec.h |    3 +++
>  sound/pci/hda/hda_proc.c  |    6 ++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h
> index 4fc3960..71864cdd 100644
> --- a/sound/pci/hda/hda_codec.h
> +++ b/sound/pci/hda/hda_codec.h
> @@ -323,6 +323,9 @@ enum {
>  #define AC_PWRST_D1			0x01
>  #define AC_PWRST_D2			0x02
>  #define AC_PWRST_D3			0x03
> +#define AC_PWRST_ERROR                  (1<<8)
> +#define AC_PWRST_CLK_STOP_OK            (1<<9)
> +#define AC_PWRST_SETTING_RESET          (1<<10)
>  
>  /* Processing capabilies */
>  #define AC_PCAP_BENIGN			(1<<0)
> diff --git a/sound/pci/hda/hda_proc.c b/sound/pci/hda/hda_proc.c
> index e59e2f0..5511de1 100644
> --- a/sound/pci/hda/hda_proc.c
> +++ b/sound/pci/hda/hda_proc.c
> @@ -459,6 +459,12 @@ static void print_power_state(struct snd_info_buffer *buffer,
>  		    get_pwr_state(pwr & AC_PWRST_SETTING),
>  		    get_pwr_state((pwr & AC_PWRST_ACTUAL) >>
>  				  AC_PWRST_ACTUAL_SHIFT));
> +	if (pwr & AC_PWRST_ERROR)
> +		snd_iprintf(buffer, " Power state error\n");
> +	if (pwr & AC_PWRST_CLK_STOP_OK)
> +		snd_iprintf(buffer, " PS: clock stop ok\n");
> +	if (pwr & AC_PWRST_SETTING_RESET)
> +		snd_iprintf(buffer, " Power state setting reset\n");

I prefer keeping the format like "AAA: BBB".
Or, can these extra bits be appended "Power:" line, such as

   Power: setting=D0, actual=D0, Error, Clock-stop-OK, Setting-reset


thanks,

Takashi