[alsa-devel] Confusing about Playback/Capture, CODEC/CODEC links, and snd_soc_dapm_link_dai_widgets()

[Liam Girdwood]

On Fri, 2012-06-01 at 00:37 +0100, Mark Brown wrote:
> On Thu, May 31, 2012 at 04:49:26PM -0600, Stephen Warren wrote:

> 
> This is all working just fine in mainline on littlemill.
> 
> > > int snd_soc_dapm_dai_get_connected_widgets(struct snd_soc_dai *dai, int stream,
> > > 	struct snd_soc_dapm_widget_list **list)
> > ...
> > > 	if (stream == SNDRV_PCM_STREAM_PLAYBACK)
> > > 		paths = is_connected_output_ep(dai->playback_widget, list);
> > > 	else
> > > 		paths = is_connected_input_ep(dai->playback_widget, list);
> 
> > I would have expected this to use capture_widget on the final line, but
> > I haven't thought about this in detail, just noticed the lack of
> > symmetry by very brief inspection.
> 
> Yes, that looks buggy.  Don't think there's any mainline users so nobody
> would notice.

Gah, it's a bug - I did have it fixed before the upstreaming but this
fix seems to have been lost.

Patch on it's way.

Liam