[alsa-devel] [PATCH 4/4] ARM: mx28evk: add missed clkmux select for saif

[Dong Aisheng]

On Sat, Jul 21, 2012 at 03:40:04PM +0800, Shawn Guo wrote:
> On Fri, Jul 20, 2012 at 05:20:27PM +0800, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng at linaro.org>
> > 
> > Added missed clkmux setting for mx28evk.
> > 
> > Cc: Mark Brown <broonie at opensource.wolfsonmicro.com>
> > Cc: Liam Girdwood <lrg at ti.com>
> > Cc: Wolfram Sang <w.sang at pengutronix.de>
> > Cc: Shawn Guo <shawn.guo at linaro.org>
> > Signed-off-by: Dong Aisheng <dong.aisheng at linaro.org>
> > ---
> >  arch/arm/mach-mxs/mach-mxs.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
> > index 8cac94b..82f27a4 100644
> > --- a/arch/arm/mach-mxs/mach-mxs.c
> > +++ b/arch/arm/mach-mxs/mach-mxs.c
> > @@ -21,6 +21,7 @@
> >  #include <asm/mach/arch.h>
> >  #include <asm/mach/time.h>
> >  #include <mach/common.h>
> > +#include <mach/digctl.h>
> >  
> >  static int __init mxs_icoll_add_irq_domain(struct device_node *np,
> >  				struct device_node *interrupt_parent)
> > @@ -79,6 +80,8 @@ static void __init imx28_evk_init(void)
> >  	clk = clk_get_sys("enet_out", NULL);
> >  	if (!IS_ERR(clk))
> >  		clk_prepare_enable(clk);
> > +
> > +	mxs_saif_clkmux_select(MXS_DIGCTL_SAIF_CLKMUX_EXTMSTR0);
> 
> Is this a board specific setup?  Or every single imx28 based board that
> wants recording function is going to need this setup?
> 
Yes, this is a board specific setup, just as non-dt does currently.
Different boards may have different setting.

> BTW, the patch needs to get rebased on v3.6-rc1, where mach-mxs.c will
> have some context update.
> 
I can do it.
This patch series was made based on Mark's sound-2.6 tree.
Do you want this one go through mxs tree and other three go through Mark's tree?
I'm thinking maybe it would be better go through one tree(Mark's or Yours) since
without this one the saif record still can not work.
Maybe go through yours may save some conflicts.

Mark,
What's your suggestion?

Regards
Dong Aisheng