[alsa-devel] [PATCH 3/5] ASoC: Tegra+ALC5632 machine: Add device tree binding documentation

[Stephen Warren]

Leon Romanovsky wrote at Tuesday, January 31, 2012 12:31 AM:
> Document device tree binding for the tegra board with ALC5632 codec
> according to datasheet functional block description.

> diff --git a/Documentation/devicetree/bindings/sound/tegra-audio-alc5632.txt

> +  ALC5632 pins:
> +
> +  * SPK_OUTP
> +  * SPK_OUTN
> +  * HP_OUT_L
> +  * HP_OUT_R
> +  * AUX_OUT_P
> +  * AUX_OUT_N

Sorry this is picky, but those are AUX_OUTP and AUX_OUTN in the block
diagram in the datasheet; only 1 underscore in the name.

Hmm, actually the block diagram and "pin assignment" diagram are
inconsistent, e.g. AUX_OUTP+AUX_OUTN in the block diagram vs.
AUX_OUT+AUX_OUTN in the pin assignment, or PHONE_N (block diagram) vs.
PHONEN (pin assignments).

Mark, do you care about this level of detail? I think we should use the
names in the pin assignments section if we do change this patch, but I
guess things are clear enough as it stands, so I'm not excessively
bothered.

> +  * LINE_IN_L
> +  * LINE_IN_R
> +  * PHONE_P
> +  * PHONE_N
> +  * MIC1_P
> +  * MIC1_N
> +  * MIC2_P
> +  * MIC2_N
> +  * MICBIAS1

-- 
nvpublic