[alsa-devel] [PATCH v2] ASoC: da7210: Add support for PLL and SRM

[Mark Brown]

On Mon, Jan 23, 2012 at 05:39:21PM +0530, Ashish Chavan wrote:
> On Mon, 2012-01-23 at 11:21 +0000, Mark Brown wrote:
> > On Mon, Jan 23, 2012 at 03:37:21PM +0530, Ashish Chavan wrote:

> > ...this code is shared between both branches (as well as the SRM case)
> > and should be factored out between them.

> We are picking values from three different tables in three cases. Even
> if we factor out this code, we will need a switch or if-else to identify
> correct table. As we are already checking those conditions, I put the
> code there. Can you please elaborate a bit, in case if I misunderstood
> your point?

The only difference between these relatively large chunks of code is the
table that's being referenced.  Either use a single table or factor
things out so that you're sharing all the code that doesn't pick the
table.