[alsa-devel] [PATCH] ASoC: Add __devinit/__devexit annotations at necessary places

Leon Romanovsky leon at leon.nu
Mon Jan 23 10:39:45 CET 2012


On Mon, Jan 23, 2012 at 05:18, Axel Lin <axel.lin at gmail.com> wrote:
> Fix below build warning when CONFIG_HOTPLUG is not set.
>
>  CC      sound/soc/codecs/alc5623.o
> sound/soc/codecs/alc5623.c:1062: warning: ‘alc5623_i2c_remove’ defined but not used
>  CC      sound/soc/codecs/alc5632.o
> sound/soc/codecs/alc5632.c:1112: warning: ‘alc5632_i2c_remove’ defined but not used
>
> Signed-off-by: Axel Lin <axel.lin at gmail.com>
> ---
>  sound/soc/codecs/alc5623.c |    4 ++--
>  sound/soc/codecs/alc5632.c |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/alc5623.c b/sound/soc/codecs/alc5623.c
> index 3feee56..08f2419 100644
> --- a/sound/soc/codecs/alc5623.c
> +++ b/sound/soc/codecs/alc5623.c
> @@ -992,7 +992,7 @@ static struct snd_soc_codec_driver soc_codec_device_alc5623 = {
>  *    low  = 0x1a
>  *    high = 0x1b
>  */
> -static int alc5623_i2c_probe(struct i2c_client *client,
> +static __devinit int alc5623_i2c_probe(struct i2c_client *client,
>                                const struct i2c_device_id *id)
>  {
>        struct alc5623_platform_data *pdata;
> @@ -1059,7 +1059,7 @@ static int alc5623_i2c_probe(struct i2c_client *client,
>        return ret;
>  }
>
> -static int alc5623_i2c_remove(struct i2c_client *client)
> +static __devexit int alc5623_i2c_remove(struct i2c_client *client)
>  {
>        snd_soc_unregister_codec(&client->dev);
>        return 0;
> diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c
> index 390e437..af9c27a 100644
> --- a/sound/soc/codecs/alc5632.c
> +++ b/sound/soc/codecs/alc5632.c
> @@ -1109,7 +1109,7 @@ static __devinit int alc5632_i2c_probe(struct i2c_client *client,
>        return ret;
>  }
>
> -static int alc5632_i2c_remove(struct i2c_client *client)
> +static __devexit int alc5632_i2c_remove(struct i2c_client *client)
>  {
>        struct alc5632_priv *alc5632 = i2c_get_clientdata(client);
>        snd_soc_unregister_codec(&client->dev);
> --
> 1.7.5.4
Thanks.

Acked-by: Leon Romanovsky <leon at leon.nu>


>
>
>



-- 
Leon Romanovsky | Independent Linux Consultant
        www.leon.nu | leon at leon.nu


More information about the Alsa-devel mailing list