[alsa-devel] imac27 12,2 (2011) model for patch_cirrus.c

[Takashi Iwai]

At Thu, 29 Dec 2011 13:00:01 +0100,
Jérémy Lal wrote:
> 
> Hi,
> it'd be glad to have patch_cirrus.c recognize model=imac27_122,
> (i'm adding a model because it's harder to auto-detect it),
> please find attached patch, tested on linux 3.2-rc7.
> I don't know anything about pin configs, just that it works with
> the ones in the patch.
> Note that i tried with model=auto (no sound) and model=imac27 (front speakers
> not muted when headphones are plugged in, and surround speakers not properly
> detected).

Thanks for the patch.  But I see a problem in the code, i.e.

> +static const struct cs_pincfg imac27_122_pincfgs[] = {
> +	{ 0x00, 0x821c9700 },
> +	{ 0x01, 0x011d9700 },
(snip)
> +	{ 0x27, 0x401f5701 },
> +	{} /* terminator */
> +};

This looks obviously wrong.  The pincfg table should contain only the
default pin-configuration values for pin widgets while you are setting
some values to all widgets.  Please minimize this entry.


thanks,

Takashi