[alsa-devel] [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Dec 20 14:51:05 CET 2012


On Thu, Dec 20, 2012 at 06:37:26AM +0000, Liu, Chuansheng wrote:

> Meanwhile, is it useful to add one warning there for that case?
> After all, in probing, set the bias to _STANDBY even idle_bias_off == 1, and calling get_runtime_sync(), it
> will let the code more obscure. So giving a warning there to indicate the driver:
> it is not suggested that in probing, set the bias to _STANDBY even idle_bias_off == 1.

Probably, send a patch please.  Like I say it is possible to start off
in _STANDBY providing the driver grabs the runtime PM reference too but
I can't think of any reason for doing that so the warning seems sensible.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20121220/309480e9/attachment.sig>


More information about the Alsa-devel mailing list