[alsa-devel] [PATCH] sound: usb-audio: full capture/playback/spdif support for Digidesign Mbox 2

[Takashi Iwai]

At Tue, 18 Dec 2012 14:08:12 +0100,
Takashi Iwai wrote:
> 
> At Tue, 18 Dec 2012 23:09:54 +1100,
> Damien Zammit wrote:
> > 
> > On 17 December 2012 21:25, Takashi Iwai <tiwai at suse.de> wrote:
> > > Thanks for the revised patch.
> > No worries! Hope we can get it in soon.
> > 
> > >> +void mbox2_setup_48_24_magic(struct usb_device *dev)
> > > This doesn't have to be global.  Make it static.
> > Check
> > 
> > > enablemagic[] and temp[] aren't used in this function.
> > > Remove them.
> > Check
> > 
> > (snd_printdd and snd_printd messages)
> > Check
> > 
> > >> +int mbox2_skip_setting_quirk(struct snd_usb_audio *chip,
> > >> +                                     int iface, int altno)
> > > Where is this function called?  I don't see the caller in your latest
> > > patch.
> > Well spotted! I believe this function is not required anymore because
> > I have hardcoded the altsettings in the quirk definition.
> > 
> > Patch version 5 attached.
> 
> Thanks!  One last favor...
> 
> > +int snd_usb_mbox2_boot_quirk(struct usb_device *dev)
> 
> This doesn't have to be a global one, as it's called only in the same
> file.  You can move this function before the caller for avoiding the
> function declaration, and ...
> 
> > diff --git a/sound/usb/quirks.h b/sound/usb/quirks.h
> > index 0ca9e91..e7e9530 100644
> > --- a/sound/usb/quirks.h
> > +++ b/sound/usb/quirks.h
> > @@ -24,6 +24,8 @@ void snd_usb_set_format_quirk(struct snd_usb_substream *subs,
> >  int snd_usb_is_big_endian_format(struct snd_usb_audio *chip,
> >  				 struct audioformat *fp);
> >  
> > +int snd_usb_mbox2_boot_quirk(struct usb_device *dev);
> > +
> 
> ... drop this.

Never mind, I fixed this by myself and merged the patch now.
It'll be included in 3.8-rc1.


thanks,

Takashi