[alsa-devel] [PATCH 1/1] ALSA: hda - bug fix for invalid connection list of more Haswell HDMI codec pins

[Lin, Mengdong]

> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai at suse.de]
> Sent: Tuesday, December 18, 2012 3:08 PM
> 
> Mengdong, your previous patch was currently dropped because it's not clear
> whether it's correct.  As asked in the previous thread, the usage of fixup is
> doubtful in this case.
> 
> Is the fix really needed only for a certain PCI (or codec) *SSID*?
> If you need to apply it generically to a certain codec, you have to choose
> another way.

Hi Takashi,

Will OEM change the PCI (or codec) SSID so that this fixup will not be applied at all?

In Haswell, there are two HD-A controllers: one for display codec and the other for legacy 3rd-party codec.
I'm not sure if OEM will change the PCI SSID of the display HD-A controller.

> >
> > +	snd_hda_override_conn_list(codec, 0x05, 3, list);
> > +	hdmi_read_pin_conn(codec, 1);
> > +
> >  	snd_hda_override_conn_list(codec, 0x06, 3, list);
> >  	hdmi_read_pin_conn(codec, 1);
> > +
> > +	snd_hda_override_conn_list(codec, 0x07, 3, list);
> > +	hdmi_read_pin_conn(codec, 1);
> 
> What's the reason to call hdmi_read_pin_conn() multiple times?
Sorry, it's not necessary here.

Thanks
Mengdong