[alsa-devel] sound: usb-audio: full capture/playback/spdif support for Digidesign Mbox 2

[Clemens Ladisch]

Takashi Iwai wrote:
> Damien Zammit wrote:
>> +	case QUIRK_MIDI_MBOX2:
>> +		/* Digidesign Mbox 2 uses MIDIMAN MIDI protocol */
>> +		umidi->usb_protocol_ops = &snd_usbmidi_midiman_ops;
>> +		err = snd_usbmidi_detect_per_port_endpoints(umidi, endpoints);
>> +		break;
>
> If the quirk handling is as same as QUIRK_MIDI_MIDIMAN, can't we just
> reuse it instead of adding yet a new type?

The endpoint detection is different; that comment applies only to the
next single line.

But while technically correct, the comment is superfluous because it
doesn't say anything that isn't obvious from the code.


Regards,
Clemens