[alsa-devel] [PATCH v2] ASoC: lm49453: Fix adc, mic and sidetone volume ranges

[Vinod Koul]

On Tue, 2012-12-11 at 11:40 -0800, Vinod Koul wrote:
> You have confused the meanings of TLV
> #define DECLARE_TLV_DB_SCALE(name, min, step, mute)
> 
> > -static const DECLARE_TLV_DB_SCALE(digital_tlv, -7650, 150, 1);
> > -static const DECLARE_TLV_DB_SCALE(port_tlv, 0, 600, 0);
> > +static const DECLARE_TLV_DB_SCALE(adc_dac_tlv, -7650, 150, 1);
> step is right here, but MAX shows up as 63 and not 18dB and where is
> mute here. You have separate bit for mute!
> > +static const DECLARE_TLV_DB_SCALE(mic_tlv, 0, 200, 1);
> step is NOT 2dB but 10dB, and where do we have mute here
Sorry I mis read data sheet, this is fine. We have 2dB steps

I have tested both of these so:
Tested-by: Vinod Koul <vinod.koul at intel.com>

Only mute bits need to be fixed here and we should be good

-- 
~Vinod