[alsa-devel] [PATCH sound-unstable] usb-audio: sync ep init fix for audioformat mistmatch

Eldad Zack eldad at fogrefinery.com
Mon Dec 3 19:48:16 CET 2012


Hi Daniel, Takashi,

On Mon, 3 Dec 2012, Takashi Iwai wrote:
> At Mon, 03 Dec 2012 10:34:29 +0100,
> Daniel Mack wrote:
> > On 01.12.2012 23:50, Eldad Zack wrote:
> > 
> > Thanks for fixing this up, and sorry for the late response on this.

It was fun to write, so I'm glad you were busy with other things :)

> > > +	if (!(fp->formats && pcm_format)) {
> > 
> > That should be a binary &, no?
> 
> Oh yeah, this must be
> 
> 	if (!(fp->formats && (1ULL << pcm_format)))

Oh, I see now I managed to somehow concoct two bugs in one line.
At least it worked because of the logical & ...

Fixed now, and of course the nr_rates.
I'll test and submit soon.

Many thanks to both of you, I appreciate it!

Cheers,
Eldad


More information about the Alsa-devel mailing list