[alsa-devel] [PATCH] ALSA: hda - Fix 'Beep Playback Switch' with no underlying mute switch

[Takashi Iwai]

At Tue, 14 Aug 2012 10:04:05 +0200,
David Henningsson wrote:
> 
> On 08/14/2012 09:44 AM, Takashi Iwai wrote:
> >>>> I admit "knew->info == snd_hda_mixer_amp_switch_info" and "kctl->private_value = 0x10000"
> >>>> looks a bit hacky, feel free to suggest something more elegant if you wish.
> >>>
> >>> Checking the amp out caps in snd_hda_mixer_amp_switch_*_beep() would
> >>> be better, IMO.  It's not necessarily limited to patch_conexant.c.
> >>
> >> Ok, here comes a second version of the patch. What do you think?
> >
> > Better to use query_amp_caps().  It's cached, so the succeeding call
> > is cheap.  For example:
> 
> Ok, third version attached.

Thanks, applied now (with a minor optimization).


Takashi

> 
> 
> 
> -- 
> David Henningsson, Canonical Ltd.
> https://launchpad.net/~diwic