[alsa-devel] [PATCH] ALSA : hda - bug fix on return value check when getting supported power states of a codec

[Lin, Mengdong]

Hi Takashi,

Sorry for using HTML format. The patch is resent with new subject:  [PATCH] ALSA : hda - bug fix on checking the supported power states of a codec.
Please review, thanks again!

Mengdong

> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai at suse.de]
> Sent: Friday, August 10, 2012 6:11 PM
> To: Lin, Mengdong
> Cc: alsa-devel at alsa-project.org; Wang, Xingchao
> Subject: Re: [PATCH] ALSA : hda - bug fix on return value check when
> getting supported power states of a codec
> 
> At Fri, 10 Aug 2012 09:15:51 +0000,
> Lin, Mengdong wrote:
> >
> > The return value of snd_hda_param_read() is -1 for an error, otherwise
> it's the supported power states of a codec.
> >
> > The supported power states is a 32-bit value. Bit 31 will be set to 1 if the
> codec supports EPSS, thus making "sup" negative. And the bit 28:5 is
> reserved as "0".
> > So a negative value other than -1 shall be further checked.
> >
> > Please refer to High-Definition spec 7.3.4.12 "Supported Power States",
> thanks!
> >
> >
> > Signed-off-by: Mengdong Lin <mengdong.lin at intel.com>
> 
> Could you resend in a normal text?  It's garbled badly with HTML in the
> signature and can't be applied.
> 
> Also, try to shorten the subject a bit more.
> 
> 
> thanks,
> 
> Takashi