[alsa-devel] [PATCH] ALSA: hda - Set channels count for HBR format

[Takashi Iwai]

At Tue,  7 Aug 2012 15:20:22 +0800,
Wang Xingchao wrote:
> 
> If it's HBR format, the channels count should be 8.

But channels count is practically always 8 when is_hbr_format() is
true, no?  The format value is calculated from runtime->channels.

Or do you see a real problem?


thanks,

Takashi

> 
> Signed-off-by: Wang Xingchao <xingchao.wang at intel.com>
> ---
>  sound/pci/hda/patch_hdmi.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index ad319d4..ae4e67e 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -1153,8 +1153,11 @@ static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo,
>  	struct hdmi_spec *spec = codec->spec;
>  	int pin_idx = hinfo_to_pin_index(spec, hinfo);
>  	hda_nid_t pin_nid = spec->pins[pin_idx].pin_nid;
> -
> -	hdmi_set_channel_count(codec, cvt_nid, substream->runtime->channels);
> +
> +	if (is_hbr_format(format))
> +		hdmi_set_channel_count(codec, cvt_nid, 8);
> +	else
> +		hdmi_set_channel_count(codec, cvt_nid, substream->runtime->channels);
>  
>  	hdmi_setup_audio_infoframe(codec, pin_idx, substream);
>  
> -- 
> 1.7.9.5
>