[alsa-devel] [PATCH 2/5] ASoC: dpcm: Add debugFS support for DPCM

[Liam Girdwood]

On Thu, 2012-04-26 at 17:44 +0100, Mark Brown wrote:
> On Wed, Apr 25, 2012 at 12:12:50PM +0100, Liam Girdwood wrote:
> 
> I've queued this to apply this but a few nits I noticed:
> 
> > +#ifdef CONFIG_DEBUG_FS
> > +	dpcm->debugfs_state = debugfs_create_u32(be->dai_link->name, 0644,
> > +			fe->debugfs_dpcm_root, &dpcm->state);
> > +#endif
> 
> I have to say that this being writable seems rather scary...  any great
> need for that?

Ah, no - will fix this and the other two incrementally.

Regards

Liam