[alsa-devel] [PATCH] ASoC: Add support for CS42L52 Codec

[Mark Brown]

On Tue, Apr 17, 2012 at 10:55:59AM -0500, Brian Austin wrote:
> On Tue, 17 Apr 2012, Mark Brown wrote:
> >On Mon, Apr 16, 2012 at 03:58:58PM -0500, Brian Austin wrote:

> >>+		snd_soc_update_bits(codec, CS42L52_PWRCTL1,
> >>+				    CS42L52_PWRCTL1_PDN_CODEC |
> >>+				    CS42L52_PWRCTL1_PDN_CHRG, 0);

> >This looks odd, especially having it in _ON - perhaps a comment
> >explaining why?

> I'm just enabling the power for the codec. Are you refering to the
> Charge Pump enable?

Both, really - it's just generally incredibly unusual to have anything
in _ON, and looking at the names these look like supplies for other bits
of the CODEC so things that I'd expect to be turned on early rather than
late in the sequence.  If it were in _PREPARE it'd be less surprising.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120417/cc2bde8f/attachment.sig